Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/json-schema): adding support descriptions for array #9757

Merged
merged 5 commits into from
Mar 1, 2024
Merged

fix(ingest/json-schema): adding support descriptions for array #9757

merged 5 commits into from
Mar 1, 2024
+74 −13

Conversation

AvaniSiddhapuraAPT
Copy link
Contributor

Checklist

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Feb 1, 2024
@anshbansal anshbansal changed the title [fix] adding support descriptions for array fix(ingest/json-schema): adding support descriptions for array Feb 1, 2024
@AvaniSiddhapuraAPT
Copy link
Contributor Author

AvaniSiddhapuraAPT commented Feb 5, 2024 •
edited
Loading

@hsheth2 @anshbansal This is the first time i am pushing some changes in code, so please do suggest if its as per the expectations or not.

@mayurinehate mayurinehate self-requested a review February 16, 2024 09:13
@asikowitz asikowitz removed the community-contribution PR or Issue raised by member(s) of DataHub Community label Feb 22, 2024
@AvaniSiddhapuraAPT AvaniSiddhapuraAPT force-pushed the ING-492_Array_description_from_json_schema branch from 0c889cc to 0ab6d19 Compare February 28, 2024 16:24
@AvaniSiddhapuraAPT AvaniSiddhapuraAPT force-pushed the ING-492_Array_description_from_json_schema branch from 0ab6d19 to 48c097e Compare February 28, 2024 16:28
@hsheth2 hsheth2 merged commit 1b4f31b into datahub-project:master Mar 1, 2024
54 checks passed
alexs-101 pushed a commit to alexs-101/datahub that referenced this pull request Mar 5, 2024
@AvaniSiddhapuraAPT
fix(ingest/json-schema): adding support descriptions for array (datah…
684e1cc 
…ub-project#9757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate left review comments

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AvaniSiddhapuraAPT @hsheth2 @mayurinehate @asikowitz